feat: allow listing only direct dependencies via --direct-deps-only#3921
Open
corneliusroemer wants to merge 5 commits intomamba-org:mainfrom
Open
feat: allow listing only direct dependencies via --direct-deps-only#3921corneliusroemer wants to merge 5 commits intomamba-org:mainfrom
corneliusroemer wants to merge 5 commits intomamba-org:mainfrom
Conversation
resolves mamba-org#3344 I can't test micromamba as I can't get it to build (see mamba-org#3920) It seems to work for mamba
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
=======================================
Coverage ? 63.37%
=======================================
Files ? 300
Lines ? 37169
Branches ? 2782
=======================================
Hits ? 23557
Misses ? 13559
Partials ? 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Klaim
reviewed
May 6, 2025
| { return (regex.empty() || std::regex_search(pkg_info.name, spec_pat)); }; | ||
|
|
||
| auto all_records = prefix_data.all_pkg_mgr_records(); | ||
| auto requested_specs = prefix_data.history().get_requested_specs_map(); |
Member
There was a problem hiding this comment.
Suggested change
| auto requested_specs = prefix_data.history().get_requested_specs_map(); | |
| const auto requested_specs = prefix_data.history().get_requested_specs_map(); |
I cant find a modification for this so I suspect const works here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3344
I can't test micromamba as I can't get it to build (see #3920)
It seems to work for mamba